Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparisons of Ref objects #41

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Fix comparisons of Ref objects #41

merged 2 commits into from
Oct 17, 2024

Conversation

keszybz
Copy link
Owner

@keszybz keszybz commented Oct 17, 2024

No description provided.

When the original file had the same object twice, once normally and
once as a reference, when writing out, we'd write the object a second
time in full, because we had Ref(x)!=y, even when x==y. We handled
this correctly in the hashing code, and the writing code, but not in
the comparison function. The fix is easy — just deference in one more
place, but it took me forever to figure out.
@keszybz keszybz merged commit 27aba8a into main Oct 17, 2024
8 checks passed
@keszybz keszybz deleted the better-derefs branch October 17, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant